Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Feb 24, 2025

Changes to increase adherence to diff edits first instead of jumping right into full file rewrite.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Prioritize apply_diff over write_to_file for editing existing files, updating instructions and tool group order accordingly.

  • Behavior:
    • Prioritize apply_diff over write_to_file for editing existing files in capabilities.ts, modes.ts, and rules.ts.
    • Update examples and instructions to reflect the new priority of apply_diff.
  • Tool Groups:
    • Reorder tools in edit group in tool-groups.ts to list apply_diff before write_to_file.
  • Instructions:
    • Modify getEditingInstructions() in rules.ts to emphasize using apply_diff when diffStrategy is enabled.

This description was created by Ellipsis for 35a56a9. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: de54a55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 24, 2025
@mrubens mrubens merged commit 4c5045d into RooCodeInc:main Feb 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants